Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cover image cropper #5678

Open
alanna opened this issue Jun 20, 2022 · 4 comments
Open

Improve cover image cropper #5678

alanna opened this issue Jun 20, 2022 · 4 comments

Comments

@alanna
Copy link
Contributor

alanna commented Jun 20, 2022

Reported by @carolineawoolard

As a collective admin I want to be able to edit the image on my page easily -- right now the tool for resizing makes it VERY hard for me to do this with images sized for a desktop and there is no suggested size for the image. See this Loom about it

@SudharakaP
Copy link
Member

SudharakaP commented Jun 20, 2022

As mentioned in the docs the optimal size for a cover image is 2736x650. But I don't think we do a good job of surfacing this information in the modal itself. Also the modal is very small on a desktop screen which makes it difficult to resize and move the image. As a simple fix, I suggest,

  • Add a info box to the modal mentioning about the optimal size for the cover image.
  • Make the cover image modal larger (~1000px width) for desktop screens.

cc: @opencollective/design

@alanna
Copy link
Contributor Author

alanna commented Jun 20, 2022

While those are good ideas, they won't really fix the issues demonstrated in the Loom, which are also about how images appear in the cropper and how the zoom is unwieldy.

Could the system automatically resize any image uploaded to the optimal width, and then let you decide which section to display using the cropper only for the vertical?

@BenJam
Copy link
Contributor

BenJam commented Jun 30, 2022

I think the option here is to do something a little like you see on profile picture editors, size the image appropriately, provide an aspect ratio mask and allow the individual to resize and move as needed:

imagecrop

this gif from twitter's interface.

@BenJam BenJam added this to the FY22Q3S1 milestone Jun 30, 2022
@Betree
Copy link
Member

Betree commented Jul 4, 2022

@BenJam isn't that what we do already? (apart from the zooming issues)

Related: #2709

@iamronen iamronen removed this from the FY22Q3S1 milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

5 participants