Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates should be listed by publication date, not creation date #5690

Closed
alanna opened this issue Jun 23, 2022 · 3 comments · Fixed by opencollective/opencollective-api#7818 or opencollective/opencollective-frontend#8083
Assignees
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple enhancement

Comments

@alanna
Copy link
Contributor

alanna commented Jun 23, 2022

Sometimes we work on a draft update for a while before publishing, and other Updates are published in the meantime. Currently when you then publish the older draft, it shows up on the Updates list down below older posts. Most recent published should be on top.

P4

@alanna alanna added the bounty candidate Potential bounty, to be reviewed. Having this tag on an issue does not qualify it for a bounty. label Jun 23, 2022
@danielsum
Copy link

Hi Alanna, it should be fixed with these 2 pull request. I've also added the possibility to order by updatedAt in case of or for other use case. Have a nice week-end :-).

@Betree Betree added complexity → simple api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) enhancement labels Jul 4, 2022
@alanna
Copy link
Contributor Author

alanna commented Aug 9, 2022

This issue is breaking our announcements I think.

I published this changelog post today but it didn't trigger a new 🔥 because it was from a draft a while ago.

@Betree
Copy link
Member

Betree commented Aug 9, 2022

I'm about to merge a fix for this issue, but there's something I'd like to highlight: not all updates have a publication date, so when viewing https://opencollective.com/opencollective/updates as an admin (only them can see drafts) I'll see all draft first, sorted by creation date. Or, with example, a typical list from the admin point of view would be:

Update 0: publishedAt: null, createdAt: '2020-07-01' 
Update 1: publishedAt: null, createdAt: '2020-01-01' 
Update 2: publishedAt: '2020-03-01', createdAt: '2020-01-01' 
Update 3: publishedAt: '2020-02-01', createdAt: '2020-05-01' 
Update 4: publishedAt: '2020-01-01', createdAt: '2020-01-01' 

I personally think we should address this with a different design, letting the admin select between "Published" and "Draft":

image

Edit: moved the suggestion to #5840

@Betree Betree removed the bounty candidate Potential bounty, to be reviewed. Having this tag on an issue does not qualify it for a bounty. label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment