Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Collective tags in database #6325

Closed
3 tasks
gustavlrsn opened this issue Jan 16, 2023 · 2 comments
Closed
3 tasks

Clean up Collective tags in database #6325

gustavlrsn opened this issue Jan 16, 2023 · 2 comments
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple task
Milestone

Comments

@gustavlrsn
Copy link
Member

gustavlrsn commented Jan 16, 2023

When adding a tag through the interface it will be lowercased automatically. When querying Collectives using tags the string is looking for lowercased versions, however, there are cases of tags that use capital letters in the database, these records won't be returned.

@gustavlrsn gustavlrsn added this to the FY23Q1C1 milestone Jan 16, 2023
@gustavlrsn gustavlrsn changed the title Clean up tags in database Clean up Collective tags in database Jan 16, 2023
@Betree Betree added complexity → simple api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) task labels Jan 16, 2023
@Betree
Copy link
Member

Betree commented Jan 16, 2023

Maybe implement that as a script in the API project to easily re-run it again in the future?

For reference, we had a migration with a similar intent a few years ago: https://github.com/opencollective/opencollective-api/blob/main/migrations/archives/20200425013627-change-tags-to-lowercase.js.

@gustavlrsn
Copy link
Member Author

Closing this, script merged in opencollective/opencollective-api#8462 and have been ran in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple task
Projects
None yet
Development

No branches or pull requests

2 participants