Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional tax field is required when submitting expense #7427

Closed
alanna opened this issue Jun 5, 2024 · 2 comments · Fixed by opencollective/opencollective-frontend#10540
Closed

optional tax field is required when submitting expense #7427

alanna opened this issue Jun 5, 2024 · 2 comments · Fixed by opencollective/opencollective-frontend#10540
Assignees
@Betree
Labels
bug frontend

Comments

@alanna
Copy link
Contributor

alanna commented Jun 5, 2024

Screenshot 2024-06-05 at 3 10 59 PM

I tried not putting the GST ID because it's optional but it says required.
@alanna alanna added the bug label Jun 5, 2024
@Betree Betree added the frontend label Jun 5, 2024
@Betree Betree self-assigned this Jun 5, 2024
@Betree
Copy link
Member

Betree commented Jun 5, 2024

@alanna should it be required?

@alanna
Copy link
Contributor Author

alanna commented Jun 5, 2024

Inputting the GST number here should be required on invoice expenses but optional on reimbursements.

@Betree Betree mentioned this issue Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Betree Betree

Labels
bug frontend
Projects
Tax system
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ExpenseForm): make ID number required for GST opencollective/opencollective-frontend
2 participants
@Betree @alanna