Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't detect colors in metadata #13

Closed
theflow opened this issue Mar 31, 2016 · 2 comments
Closed

don't detect colors in metadata #13

theflow opened this issue Mar 31, 2016 · 2 comments

Comments

@theflow
Copy link
Contributor

theflow commented Mar 31, 2016

  it("should parse metadata without detecting colors", () => {
    var test = `
group:
  oct/:
    backgroundColor: #EEEEEE
`;
    var tree = parser.parse(test);
  });

Parse error on line NaN: Unexpected '#'

I don't think it should detect a color here, just treat it as a string

@halfbyte
Copy link
Contributor

halfbyte commented Apr 1, 2016

Quite the contrary: The bug is that the color is not correctly parsed. We need colors (and references!) as meta values. I'll take a look.

@halfbyte
Copy link
Contributor

halfbyte commented Apr 1, 2016

Colors are now parsed, as well as references.

@halfbyte halfbyte closed this as completed Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants