Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RebootStatus RPC ambiguity #54

Open
amanand opened this issue Aug 26, 2021 · 2 comments · May be fixed by #99
Open

RebootStatus RPC ambiguity #54

amanand opened this issue Aug 26, 2021 · 2 comments · May be fixed by #99

Comments

@amanand
Copy link

amanand commented Aug 26, 2021

Hi,
RebootStatusRequest can have multiple subcomponents whereas it has just a single response. So there is no way to deterministically respond from target as to which ones are in what state in a multi-node setup. Can someone please clarify on the expected behavior or if there needs to be any modification?

message RebootStatusRequest {
repeated types.Path subcomponents = 1; // optional sub-component.
}

message RebootStatusResponse {
bool active = 1; // If reboot is active.
uint64 wait = 2; // Time left until reboot.
uint64 when = 3; // Time to reboot in nanoseconds since the epoch.
string reason = 4; // Reason for reboot.
uint32 count = 5; // Number of reboots since active.
}

Thanks,
Amish

@greg-dennis
Copy link
Contributor

@marcushines @robshakir thoughts?

@xw-g
Copy link
Contributor

xw-g commented Sep 30, 2022

a proposal: #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants