Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnoi cert.proto: Need clarity on RevokeCertificates rpc #87

Open
Devendra-Vamsi opened this issue Jul 15, 2022 · 1 comment
Open

gnoi cert.proto: Need clarity on RevokeCertificates rpc #87

Devendra-Vamsi opened this issue Jul 15, 2022 · 1 comment

Comments

@Devendra-Vamsi
Copy link

Let's say the target device uses certificate named "ee-cert1" to establish connection with the gNOI client. After establishment of this connection, if the gNOI client calls RevokeCertificates() rpc with certificate_id "ee-cert1" then what is the expected behavior from Target device? Should it revoke the certificate "ee-cert1" and return success or should it fail this revocation with error message like "certificate in use"?

@samribeiro
Copy link
Member

This is not specified in the service definition. The proto needs to be augmented to specify it. There is no currently commonly agreed preference. At the moment you are free to implement your preferred behavior. However here are a few notes:

  • An endpoint can potentially have more than one certificate ID assigned, therefore some revocations can likely be executed without impacting the endpoint, just by removing the assigned ID from the list;
  • The current CertificateInfo->endpoints->type may not have all the endpoint types supported, therefore it may not be possible for a system to list what certificate ids are actually being used by any endpoint solely by using this service, therefore the safer approach for revoking a used certificate would be to fail with an error message;
  • From a security perspective, if a certificate is revoked, immediately all endpoints should cease to use it, regardless of whether it is currently in use or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants