Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certz: Need clarification on usage of ExistingEntity #193

Open
macb2625 opened this issue May 21, 2024 · 1 comment
Open

Certz: Need clarification on usage of ExistingEntity #193

macb2625 opened this issue May 21, 2024 · 1 comment

Comments

@macb2625
Copy link

macb2625 commented May 21, 2024

As part of ExistingEntity(https://github.com/openconfig/gnsi/blob/main/certz/certz.proto#L580)message do we also send version and created on fields?.Here it's expected us to just copy the mentioned entity from existing profile. So is it implied that we copy version and created on fields as well for that particular entity from the profile mentioned in the request?

so my question is do we need to any version field checking for this type of rotate request? if yes then how?
Do we need to check versions between the destination profile entity(if present) and source profile entity? for example:

  1. profile being rotated has a CertficateChain with version "v1.1".
  2. profile from which the candidate CertficateChain needs to be copied also has "v1.1" so we reject this request?
    If thats the case then version and created on field should not be sent as part of ExistingEntity request.
    https://github.com/openconfig/gnsi/blob/main/certz/certz.proto#L280
    https://github.com/openconfig/gnsi/blob/main/certz/certz.proto#L542
@macb2625
Copy link
Author

@morrowc @marcushines can you please check this query?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant