Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance: Allow 405 Status for all tear down / deletes #179

Closed
markphelps opened this issue Aug 11, 2020 · 5 comments · Fixed by #185
Closed

Conformance: Allow 405 Status for all tear down / deletes #179

markphelps opened this issue Aug 11, 2020 · 5 comments · Fixed by #185

Comments

@markphelps
Copy link
Contributor

Much like what was implemented in https://github.com/opencontainers/distribution-spec/pull/151/files#diff-fddb7a1636af89303c8fcf32651486a9R260 for 02_push_test.go, it would be great if you could allow this for all the other tests.

For example, our registry does not currently support deletion through the CLI, so all of the other tests are failing in the tear down step with errors such as:

 OCI Distribution Conformance Tests
/go/src/github.com/opencontainers/distribution-spec/conformance/00_conformance_suite_test.go:12
  Pull
  /go/src/github.com/opencontainers/distribution-spec/conformance/01_pull_test.go:14
    Teardown
    /go/src/github.com/opencontainers/distribution-spec/conformance/01_pull_test.go:154
      Delete manifest created in setup [It]
      /go/src/github.com/opencontainers/distribution-spec/conformance/01_pull_test.go:191

      Expected
          <int>: 405
      to be <
          <int>: 300

      /go/src/github.com/opencontainers/distribution-spec/conformance/01_pull_test.go:197

It seems like HTTP 405 s should be allowed in the teardown of the following tests:

  1. 01_pull_test.go
  2. 03_discovery_test.go
  3. 04_management_test.go

Thanks!

@markphelps
Copy link
Contributor Author

@jdolitsky friendly bump

@jdolitsky
Copy link
Member

@markphelps I think that this is reasonable. To clarify - you're talking specifically about the conformance tests and not changing error codes listed here https://github.com/opencontainers/distribution-spec/blob/master/spec.md#endpoints ?

@markphelps
Copy link
Contributor Author

@jdolitsky yup correct. just talking about changing the conformance tests to allow for HTTP 405 status responses for all tear down calls to delete

@markphelps
Copy link
Contributor Author

I can happily create a PR as well if you like

@jdolitsky
Copy link
Member

@markphelps PR would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants