Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expressions missing for name, reference, etc. #183

Closed
vsoch opened this issue Sep 11, 2020 · 8 comments
Closed

Regular expressions missing for name, reference, etc. #183

vsoch opened this issue Sep 11, 2020 · 8 comments
Milestone

Comments

@vsoch
Copy link
Contributor

vsoch commented Sep 11, 2020

Heyo! Is there a regular expression for the <name> attribute?

refers to the namespace of the repository. MUST be either (a) the digest of the manifest or (b) a tag name. The MUST NOT be in any other format.

I was using [a-z0-9]+(?:[._-][a-z0-9]+)* but I was under the impression that the name should allow a slash (e.g., owner/repository). Thanks!


Update: we would want the regular expressions for any fields mentioned for the distribution spec to be included here, in a code-agnostic format (e.g., the link below compiles it in golang).

@vsoch vsoch changed the title Regular expression for <name> Regular expression for <name> Sep 11, 2020
@sajayantony
Copy link
Member

@vsoch
Copy link
Contributor Author

vsoch commented Sep 11, 2020

yes perfect, thank you!

@vsoch vsoch closed this as completed Sep 11, 2020
@vsoch
Copy link
Contributor Author

vsoch commented Sep 11, 2020

Just curious, why isn't this knowledge ported over to this repository?

@sajayantony
Copy link
Member

@mikebrow @jdolitsky - I don’t know if this repo has the constraints called out. @vsoch It does makes sense to have it in the spec repo.

@vsoch
Copy link
Contributor Author

vsoch commented Sep 11, 2020

There is detail about regular expressions for the range in spec.md but the name (and others) were missing. I can re-open the issue and rescope to have regular expressions represented here! I think this is important because someone should be able to read the spec and implement the distribution spec without needing to reference other repos.

@vsoch vsoch reopened this Sep 11, 2020
@vsoch vsoch changed the title Regular expression for <name> Regular expressions missing for name, reference, etc. Sep 11, 2020
@jdolitsky jdolitsky mentioned this issue Sep 11, 2020
14 tasks
@jdolitsky
Copy link
Member

Hey yall, I've just added it to the spec revamp epic: #126

@vsoch
Copy link
Contributor Author

vsoch commented Sep 11, 2020

Thank you!

@jdolitsky
Copy link
Member

Resolved by #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants