Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec seems to be missing cross-repo mounting entirely #186

Closed
jonjohnsonjr opened this issue Sep 18, 2020 · 8 comments
Closed

Spec seems to be missing cross-repo mounting entirely #186

jonjohnsonjr opened this issue Sep 18, 2020 · 8 comments
Milestone

Comments

@jonjohnsonjr
Copy link
Contributor

This section from the docker spec seems to have been dropped: https://github.com/docker/distribution/blob/5cb406d511b7b9163bff9b6439072e4892e5ae3b/docs/spec/api.md#cross-repository-blob-mount

I see that some info is still present in detail.md, which isn't referenced by spec.md at all: https://github.com/opencontainers/distribution-spec/blob/master/detail.md

Was this omission intentional?

@jdolitsky
Copy link
Member

I think the omission is intentional, as mounting isn't fully worked out for 1.0 release. Was discussed that this, along with extensions, and other topics can be reworked/re-added for subsequent releases.

It is intended that detail.md will be referenced in spec.md prior to 1.0

@jonjohnsonjr
Copy link
Contributor Author

Was discussed that this, along with extensions, and other topics can be reworked/re-added for subsequent releases.

Interesting! Do you remember where the discussion took place? Have a link handy?

@jdolitsky
Copy link
Member

@jonjohnsonjr It was a vidchat several weeks ago between maintainers related to getting this PR merged: #178

Since we didn't want to lose useful bits, big chunk was saved off into details.md, although it shouldn't be considered "official". Working on adding that language in #188

@vbatts - correct me if I'm wrong about punting extensions stuff until after 1.0

@dmcgowan
Copy link
Member

I think the omission is intentional, as mounting isn't fully worked out for 1.0 release.

I don't think that is accurate. Mounting is fully defined and regularly used today, I haven't heard of any aspect of it that was considered to be in-progress.

@dmcgowan dmcgowan added this to the v1.0.0-rc1 milestone Sep 27, 2020
@jdolitsky
Copy link
Member

@dmcgowan ok, lets add it back. Which section should it be defined under?

@dmcgowan
Copy link
Member

Next to regular blob push. Used when initiating a new upload

@jdolitsky
Copy link
Member

@jonjohnsonjr @dmcgowan please see #204

@jdolitsky
Copy link
Member

Resolved by #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants