-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving usage of reference
terminology
#216
Comments
Also, I'm not quite sure where else to put this, and whether it warrants it's own issue in this or another OCI project, since I don't think any of the OCI projects cover the syntax of the client side "reference format", however the docker definition is either ambiguous or possibly incorrect when specifying the regex for the domain. Docker's comments indicate the registry name can optionally have a Is there somewhere in OCI where we specify these client side reference regex strings, or some equivalent? |
I'd throw in |
This was also source of confusion to me and leaks into issues when writing code (it would be good to have unambiguous definitions). I note the following text from the bottom of the image spec:
Which suggests to me that these definitions may move spec in the future. +1 for |
In the current spec, there are multiple references to
<reference>
as either a tag or digest. However in the Docker context, that same term means the entire pointer to pull a specific image, e.g.ubuntu:latest
orquay.io/prometheus/node-exporter:v1.0.0
orbusybox@sha256:4fe8827f51a5e11bb83afa8227cbccb402df840d32c6b633b7ad079bc8144100
. Trying to keep straight whether a tag is the whole image name, or just the part after the colon, and knowing if an image name is the repo name or a full reference to a specific image, gets confusing. So I would recommend that the spec define this term at the top and consistently use them throughout the spec.The text was updated successfully, but these errors were encountered: