[proposal/rfc] Use github-native review process, say goodbye to pullapprove

[kolyshkin]

(similar to opencontainers/runc#2388)

Pullappove was probably added when github did not have its own mechanism to do LGTMs. For quite some time, such a mechanism exists: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/approving-a-pull-request-with-required-reviews

There is also a mechanism to require a certain number of LGTMs before it is possible to merge a PR: https://help.github.com/en/github/administering-a-repository/about-required-reviews-for-pull-requests, although I don't think it is necessary, since all the moderators here are able to count how many green check marks are there in the top left corner of a PR page.

So, unless I am missing something, there is no value that pullapprove adds to what github has.

Please let me know what you think, @opencontainers/runtime-spec-maintainers

[vbatts]

yes, please

[crosbymichael]

LGTM

[hqhq]

LGTM

[thaJeztah]

LGTM (non binding)

[kolyshkin]

@tianon @mrunalp @caniszczyk PTAL

[tianon]

LGTM, although I think it's useful to have it require the proper number (requires less cognitive effort to verify, so more likely to get it right consistently)

[mrunalp]

LGTM

[thaJeztah]

although I think it's useful to have it require the proper number

Yes, it's possible to configure the number of approvals required (and to disallow "stale" reviews)

[crosbymichael]

LGTM

[kolyshkin]

Looks like we have a consensus, and so we can move on to implementing the change. I do not have any admin rights over that repo, so can anyone from @opencontainers/runtime-spec-maintainers please implement that?

[cyphar]

@caniszczyk can set this up.

[kolyshkin]

Alas, this is still not implemented, nor do I have admin access to do it. @caniszczyk please? 🙏🏻

[AkihiroSuda]

Seems completed