Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/var/configs/cloud-configurations.json WRN and ERR messages filling logs #2748

Closed
mattray opened this issue May 14, 2024 · 16 comments · Fixed by #2785
Closed

/var/configs/cloud-configurations.json WRN and ERR messages filling logs #2748

mattray opened this issue May 14, 2024 · 16 comments · Fixed by #2785
Assignees
Labels
E3 Estimated level of Effort (1 is easiest, 4 is hardest) needs-follow-up opencost OpenCost issues vs. external/downstream P2 Estimated Priority (P0 is highest, P4 is lowest)

Comments

@mattray
Copy link
Collaborator

mattray commented May 14, 2024

Describe the bug
The logs are full of the following messages:

2024-05-14T07:36:43.43448165Z WRN Controller: pullWatchers: failed to load config statuses from file: open /var/configs/cloud-configurations.json: no such file or directory. Proceeding to create the file
2024-05-14T07:36:43.43465676Z ERR Controller: pullWatchers: failed to save statuses failed to save config statuses to file: open /var/configs/cloud-configurations.json: no such file or directory

even if you turn off Cloud Costs in your Helm chart.

opencost:
  cloudCost:
    enabled: false

It was noticed in opencost/opencost-helm-chart#201 (comment) as well

To Reproduce
Steps to reproduce the behavior:

  1. Install OpenCost 1.110.0
  2. Check the logs

Expected behavior
This shouldn't show up if Cloud Costs are disabled.

Which version of OpenCost are you using?
1.110.0

Additional context
I haven't been able to test with a working instance of Cloud Costs, so they may be related or my accounts have been changed out from under me.

@mattray mattray added P2 Estimated Priority (P0 is highest, P4 is lowest) E3 Estimated level of Effort (1 is easiest, 4 is hardest) opencost OpenCost issues vs. external/downstream and removed needs-triage needs-follow-up labels May 14, 2024
@SayakMukhopadhyay
Copy link

Looking at the diff at v1.110...develop#diff-c9127ce2d87ae5fe988d6b5f16b63f7ba022998d617dfbafd0381bfda6ceba41L54, it seems like that this issue might not be present in the develop branch.

@cliffcolvin
Copy link
Member

@SayakMukhopadhyay thank you for that, it was my first question. I'll find what we need here and cherry-pick to the release branch before we build a patch. Thank you for the feedback!!

@jeremybouchet44
Copy link

Hello @cliffcolvin ,
I encounter the same problem with the error ERR Controller: pullWatchers: failed to save statuses failed to save config statuses to file: open /var/configs/cloud-configurations.json: no such file or directory

Do you know when approxamitively the new fix will be published ?

@gabrielemontano
Copy link

+1

@thomasvn
Copy link
Contributor

I believe this issue will be fixed by PR #2691. I don't think this has made it into a release yet. @Sean-Holcomb to confirm?

@JoshuaFurman
Copy link

I'm seeing this issue as well... is there any traction on this getting merged into main soon?

@mattray mattray closed this as completed Jun 6, 2024
@mattray mattray reopened this Jun 6, 2024
@mattray
Copy link
Collaborator Author

mattray commented Jun 6, 2024

Still seeing this in the develop branch

@mattray
Copy link
Collaborator Author

mattray commented Jun 6, 2024

Actually, it's gone if

  cloudCost:
    enabled: false

is in your Helm chart, but it's there otherwise. Let's leave this open until it can be verified with a working Cloud Costs, mine's broken and I'm working on getting it fixed.

@Sean-Holcomb
Copy link
Contributor

Sean-Holcomb commented Jun 6, 2024

I have added a patch that will allow you to use

  cloudCost:
    enabled: false

in v1.110 #2776

@mattray
Copy link
Collaborator Author

mattray commented Jun 7, 2024

@Sean-Holcomb It looks like we're going to do 1.111.0 next week instead of 1.110.1, just to confirm that the fix is in develop? @cliffcolvin can you confirm?

@Sean-Holcomb
Copy link
Contributor

Ive got, fixes in both 1.110 and dev branches now

@andromeda306
Copy link

I've got targetRevision: 1.38.1 with 1.110 and the additional chart value however this still seems to be an issue.

        opencost:
          cloudCost:
            enabled: false

Is there anything else that could be a culprit? Recently made an upgrade from v1.29.0 to 1.38.1

@martinsolberg
Copy link

Same thing here, I'm on the 1.38.1 and 1.110, and I'm seeing the same error messages.

@annamagdalenakosek
Copy link

Same here, I'm on the 1.38.1 with 1.110, errors persist.

@annamagdalenakosek
Copy link

@Sean-Holcomb any updates on this?

@mattray
Copy link
Collaborator Author

mattray commented Jun 18, 2024

@annamagdalenakosek it will be in the next OpenCost release, hopefully this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E3 Estimated level of Effort (1 is easiest, 4 is hardest) needs-follow-up opencost OpenCost issues vs. external/downstream P2 Estimated Priority (P0 is highest, P4 is lowest)
Projects
None yet
Development

Successfully merging a pull request may close this issue.