Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support manually provisioned PVs in the model #69

Closed
AjayTripathy opened this issue May 1, 2019 · 2 comments
Closed

Support manually provisioned PVs in the model #69

AjayTripathy opened this issue May 1, 2019 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@AjayTripathy
Copy link
Contributor

AjayTripathy commented May 1, 2019 •
edited

Today, we're looking up requests and computing an allocation based on PVCs, not PVs. We do not have a configured daemon in our stack that exports information like "size" about PVs themselves-- we rely on the PVC data.

However, PVCs do not have a storageclass assigned to them if they use manually provisioned disks. This means for manually provisioned disks, we will need to join the prometheus query here for PVCs today with the data on the actual PV to get storage class in all cases.
@AjayTripathy AjayTripathy mentioned this issue May 1, 2019
Closed
@AjayTripathy AjayTripathy added bug Something isn't working good first issue Good for newcomers labels May 1, 2019
@AjayTripathy
Copy link
Contributor Author

It looks like KSM 1.6 fixes this: (ksm #674 ) with kube_persistentvolume_capacity

@AjayTripathy
Copy link
Contributor Author

We have upgraded to KSM 1.6-- we will need to update the queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dwbrown2 @AjayTripathy