Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 Compatibility #544

Open
lisaleague opened this issue Aug 7, 2016 · 5 comments
Open

PHP 7 Compatibility #544

lisaleague opened this issue Aug 7, 2016 · 5 comments

Comments

@lisaleague
Copy link

Hi I ran this PHP 7 compatibility checker https://wordpress.org/plugins/php-compatibility-checker/ and noticed this one error. Please let me know when this will be fixed and ready to go for PHP 7, thanks.

Name: BadgeOS

FILE: /nas/content/live/sitename/wp-content/plugins/badgeos/includes/p2p/mustache/Mustache.php

FOUND 1 ERROR AFFECTING 1 LINE

701 | ERROR | 'clone' is a reserved keyword introduced in PHP version 5.0 and cannot be invoked as a function (T_CLONE)

FILE: /nas/content/live/sitename/wp-content/plugins/badgeos/includes/cmb/init.php

FOUND 1 ERROR AFFECTING 1 LINE

208 | ERROR | Function name, class name, namespace name or constant name can not be reserved keyword 'dir' (since version 5.3)

@asahi-badgeos
Copy link
Collaborator

Hi @lisaleague ,

Thank you for reporting this. We will be updating BadgeOS for PHP 7 Compatibility in our upcoming minor release. I will notify you once this has been completed.

@kalico1
Copy link

kalico1 commented Oct 3, 2016

+1 and Watching. Thank you.

@mikebrownvb
Copy link

Same errors found.
Name: BadgeOS

It's not January 16th 2017. Has this issue been addressed yet?

FOUND 1 ERROR AFFECTING 1 LINE

208 | ERROR | Function name, class name, namespace name or constant name can not be reserved keyword 'dir' (since PHP version 5.3)

FOUND 1 ERROR AFFECTING 1 LINE

701 | ERROR | 'clone' is a reserved keyword introduced in PHP version 5.0 and cannot be invoked as a function (T_CLONE)

@peeter78
Copy link

Has it been solved? Is BadgeOS php 7.1 compatible?

@lkraav
Copy link

lkraav commented Jul 21, 2018

Has it been solved? Is BadgeOS php 7.1 compatible?

We've been running on 7.0 and 7.1 for a year and longer, it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants