Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CrowdStrike TIP] Manage logs of unsupported indicator errors. #2212

Open
Lhorus6 opened this issue Jun 13, 2024 · 0 comments
Open

[CrowdStrike TIP] Manage logs of unsupported indicator errors. #2212

Lhorus6 opened this issue Jun 13, 2024 · 0 comments
Labels
feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team

Comments

@Lhorus6
Copy link
Contributor

Lhorus6 commented Jun 13, 2024

Use case

For the CrowdStrike import connector

When an indicator type is not supported, a log ERROR is raised, which is very noisy.

Since the fact that the indicator is not supported is known, it shouldn't be an ERROR (but rather an INFO, perhaps?).

The aim is to have relevant ERROR logs and not to be swamped by "unsupported indicators".

Here's an example log:

{"timestamp": "2024-06-12T09:40:10.186394Z", "level": "ERROR", "name": "CrowdStrike", "message": "Failed to build indicator bundle for 'password_paklandpvt0110#2$1': Unsupported indicator type: password", "exc_info": "Traceback (most recent call last):\n File \"/opt/opencti-connector-crowdstrike/crowdstrike/indicator/importer.py\", line 248, in _create_indicator_bundle\n bundle_builder = IndicatorBundleBuilder(bundle_builder_config)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/opt/opencti-connector-crowdstrike/crowdstrike/indicator/builder.py\", line 141, in __init__\n self.observation_factory = self._get_observation_factory(self.indicator.type)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File \"/opt/opencti-connector-crowdstrike/crowdstrike/indicator/builder.py\", line 149, in _get_observation_factory\n raise TypeError(f\"Unsupported indicator type: {indicator_type}\")\nTypeError: Unsupported indicator type: password"} {"timestamp": "2024-06-12T09:40:10.186864Z", "level": "ERROR", "name": "CrowdStrike", "message": "Discarding indicator password_paklandpvt0110#2$1 bundle", "exc_info": "NoneType: None"}

I've spoken to @helene-nguyen about this, and she knows the situation. But if you need, please contact me.

@Lhorus6 Lhorus6 added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team
Projects
None yet
Development

No branches or pull requests

1 participant