Interpolation of polyshapes in CVAT #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int context menu is opened
…s during redraw, do not allow changing frame during redraw
Pull Request Test Coverage Report for Build 6032
💛 - Coveralls |
zhiltsov-max
reviewed
Jun 5, 2020
nmanovic
requested changes
Jun 15, 2020
|
@ActiveChooN , could you please test and review the PR? Need to merge it ASAP. |
|
@bsekachev , could you please attach your great presentation in PDF format for future reference? |
Sure. I pushed .pdf to the repository and attached .pptx to the PRs just in case if we want to change it later. |
azhavoro
previously approved these changes
Jun 16, 2020
ActiveChooN
reviewed
Jun 16, 2020
cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/object-item.tsx
Outdated
Show resolved
Hide resolved
ActiveChooN
previously approved these changes
Jun 18, 2020
ActiveChooN
previously approved these changes
Jun 19, 2020
|
We are waiting for your review |
ActiveChooN
reviewed
Jun 22, 2020
nmanovic
approved these changes
Jun 22, 2020
frndmg
pushed a commit
to signatrix/cvat
that referenced
this pull request
Aug 5, 2020
* cvat-core interpolation * Unlocked polyshapes * Updated versions * Second implementation * Splitted line * Inverse, set start point, fixed editing a bit, point menu refactoring * Removed extra code, fixed bug: Cannot open shape context menu when point context menu is opened * Do not close shape context menu on change shap[e * Improved editing * Updated mouseevents to edit/delete, added ability to redraw (shift + N) * Ignore tags when redraw * Ingoring tags on canvas, added method isAbleToChangeFrame, hide shapes during redraw, do not allow changing frame during redraw * Canceled advanced editing for polygons * A couple of fixes in interpolation, editing, reducing number of points * Moved change orientation functionality * Fixed interpolation algorithm * Zero division issue * Zero division issue * Segment minimization * Server implementation * Keyframe set to False * Simplified code, fixed server side code * Updated changelog.md * Added pdf describing interpolation * Resolved some issues * Updated UI version * Updated canvas version * Fixed host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Need to be able interpolate not only rectangles, but also polygones, polylines and points. A lot of customers asked us about it.
Interpolation algorithm works when both polygons (left and right) drawn in the same orientation and with the same start point (according to labeled object). It is better if the latest points of these polygon also stay at the same place of labeled object.
How has this been tested?
Manual testing
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Resolved #824
Resolved #1032
PPTX file describes how interpolation works:
Interpolation.pptx