Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kibana working time calculation #1654

Merged
merged 2 commits into from
Jun 6, 2020
Merged

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Jun 5, 2020

Rename 'working time' to 'working time' event field to unify old and new UIs.

resolve #1642

Motivation and context

Kibana analytics doesn't calculate working_time when a user works in new UI

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@azhavoro azhavoro changed the title renamed 'working time' field to 'working_time' in logstash and kibana Fix Kibana working time calculation Jun 5, 2020
@azhavoro azhavoro requested a review from nmanovic as a code owner June 5, 2020 11:47
@coveralls
Copy link

coveralls commented Jun 5, 2020

Pull Request Test Coverage Report for Build 5508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.686%

Totals Coverage Status
Change from base Build 5502: 0.0%
Covered Lines: 10895
Relevant Lines: 16180

💛 - Coveralls

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit c83b66b into develop Jun 6, 2020
@bsekachev bsekachev deleted the az/fix_working_time_field branch June 9, 2020 11:11
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
* renamed 'working time' field to 'working_time' in logstash and kibana

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVAT new UI: a problem with Kibana analytics
3 participants