Allow import of single boxes in MOT format #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6061
💛 - Coveralls |
zhiltsov-max
changed the title
azhavoro
previously approved these changes
Jun 19, 2020
nmanovic
reviewed
Jun 19, 2020
| @@ -45,6 +45,17 @@ def _import(src_file, task_data): | |||
|
|
|||
| track_id = ann.attributes.get('track_id') | |||
| if track_id is None: | |||
| # Extension. Import regular boxes: | |||
| task_data.add_shape(task_data.LabeledShape( | |||
There was a problem hiding this comment.
Why don't create a track with only one bounding box?
There was a problem hiding this comment.
Is it any better? This would not preserve the original annotations, as all tracks are exported as tracks, even single-framed. We can, possibly, convert regular boxes to such tracks.
There was a problem hiding this comment.
MOT is for tracks only. Right? How are you going to dump a track which has two shapes:
- First with outside=False, frame=0
- Second with outside=True, frame=1?
There was a problem hiding this comment.
MOT is mostly for tracks, look here: https://motchallenge.net/instructions/. Almost every version has <[track] id> field set (idx 2), but not MOT17det, which contains just boxes and -1 as id. So we can safely assume that bboxes are supported via this extension.
nmanovic
added this to Review in progress
in Dataset framework (Datumaro)
via automation
nmanovic
approved these changes
Jun 22, 2020
Dataset framework (Datumaro)
automation
moved this from Review in progress
to Reviewer approved
Jun 22, 2020
frndmg
pushed a commit
to signatrix/cvat
that referenced
this pull request
Aug 5, 2020
* Allow single boxes in MOT format * update changelog Co-authored-by: Nikita Manovich <40690625+nmanovic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the use case found in #1463
Motivation and context
Extends MOT format support with import of single boxes (without tracks). This is an extension for the original format, as it does not expect non-track annotations.
How has this been tested?
Unit test
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.