-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow attributes in COCO format #1782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6193
💛 - Coveralls |
@zhiltsov-max there is the same issue with checkbox as for VOC attributes #1792 . |
nmanovic
previously approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@azhavoro , could you please look? |
Dataset framework (Datumaro)
automation
moved this from Reviewer approved
to Review in progress
Jun 26, 2020
Complexity increasing per file
==============================
- datumaro/datumaro/plugins/coco_format/extractor.py 2
See the complete overview on Codacy |
azhavoro
approved these changes
Jun 26, 2020
nmanovic
approved these changes
Jun 30, 2020
Dataset framework (Datumaro)
automation
moved this from Review in progress
to Reviewer approved
Jun 30, 2020
frndmg
pushed a commit
to signatrix/cvat
that referenced
this pull request
Aug 5, 2020
* allow attributes in coco * update changelog * update cli * update coco cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1792
Motivation and context
Closes #1337
Allows to read and write annotation attributes in
attributes
field of COCO annotations.Exporting is enabled by default and can be disabled with
--allow-attributes=False
CLI option of Datumaro export.How has this been tested?
Unit tests
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.