Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes: logout #1812

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Bug fixes: logout #1812

merged 3 commits into from
Jun 30, 2020

Conversation

lizhming
Copy link
Contributor

@lizhming lizhming commented Jun 28, 2020

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Resolve #1810

@coveralls
Copy link

coveralls commented Jun 28, 2020

Pull Request Test Coverage Report for Build 6254

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 65.158%

Totals Coverage Status
Change from base Build 6253: 0.04%
Covered Lines: 11049
Relevant Lines: 16548

💛 - Coveralls

@ActiveChooN
Copy link
Contributor

@lizhming, thanks a lot, could you just add changes to changelog?

@bsekachev
Copy link
Member

bsekachev commented Jun 29, 2020

@lizhming

Hi, thanks for the PR. Please, fill out checkboxes in PR description. We aren't permitted to merge it without some of them.

Also need to update a version of cvat-ui using command npm version patch in cvat-ui directory.

@lizhming lizhming requested a review from nmanovic as a code owner June 30, 2020 11:24
CHANGELOG.md Outdated Show resolved Hide resolved
@nmanovic
Copy link
Contributor

@lizhming , thanks for the PR. Great to see such contributions.

@nmanovic nmanovic merged commit 681ea2b into cvat-ai:develop Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logout button not working
5 participants