Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVAT-UI] Fixed displaying on canvas in some cases #1834

Merged
merged 2 commits into from Jul 2, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jul 2, 2020

Motivation and context

One of bugs affects some functionality, more specific - propagation (reported on gitter).
Resolve #1819

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Jul 2, 2020
@bsekachev bsekachev added this to In progress in UI via automation Jul 2, 2020
@bsekachev bsekachev changed the title Fixed displaying on canvas in some cases [CVAT-UI] Fixed displaying on canvas in some cases Jul 2, 2020
@coveralls
Copy link

coveralls commented Jul 2, 2020

Pull Request Test Coverage Report for Build 6285

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 65.141%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 5 76.18%
Totals Coverage Status
Change from base Build 6272: -0.02%
Covered Lines: 11045
Relevant Lines: 16548

💛 - Coveralls

@bsekachev bsekachev merged commit 18f6b2f into develop Jul 2, 2020
UI automation moved this from In progress to Done Jul 2, 2020
@bsekachev bsekachev deleted the bs/fixed_canvas_displaying branch July 3, 2020 09:31
@csgwon
Copy link

csgwon commented Jul 3, 2020

I've confirmed that it now works. Thanks for the fix!!!

@bsekachev
Copy link
Member Author

@csgwon Great, I will close the #1838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
UI
  
Done
Development

Successfully merging this pull request may close these issues.

Wrong behaviour in split track feature. One of tracks gets outside
4 participants