Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVAT-UI: Couple of fixes #1892

Merged
merged 4 commits into from
Jul 15, 2020
Merged

CVAT-UI: Couple of fixes #1892

merged 4 commits into from
Jul 15, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jul 13, 2020

Motivation and context

  1. Fixed: Interpolation algorithm, array must be flatten
  2. Fixed: When redraw polygon with enabled feature of autobordering previous points are visible

How has this been tested?

The PR fixes couple of bugs reported by internal team and our community

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Resolve #1882
Resolve #1886

@bsekachev bsekachev added the bug Something isn't working label Jul 13, 2020
@bsekachev bsekachev added this to In progress in UI via automation Jul 13, 2020
@coveralls
Copy link

coveralls commented Jul 13, 2020

Pull Request Test Coverage Report for Build 6463

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 64.928%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cvat/apps/dataset_manager/annotation.py 1 2 50.0%
Totals Coverage Status
Change from base Build 6461: 0.01%
Covered Lines: 11035
Relevant Lines: 16588

💛 - Coveralls

@bsekachev
Copy link
Member Author

@ActiveChooN @zhiltsov-max Could you please look at the PR? It is quite critical

@bsekachev bsekachev requested a review from nmanovic as a code owner July 15, 2020 09:35
@@ -523,7 +524,7 @@ def match_left_right(left_curve, right_curve):
return matching

def match_right_left(left_curve, right_curve, left_right_matching):
matched_right_points = left_right_matching.values()
matched_right_points = list(chain.from_iterable(left_right_matching.values()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it may be better to use some kind of search tree here for better performance. For instance, you can create a list of id(obj) and put it into a set.

@bsekachev bsekachev merged commit e92014e into develop Jul 15, 2020
UI automation moved this from In progress to Done Jul 15, 2020
@bsekachev bsekachev deleted the bs/fixed_interpolation branch July 15, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
UI
  
Done
Development

Successfully merging this pull request may close these issues.

Problem moving polygon points - unexpected behaviors CVAT new UI: a bug with polygon's interpolation
4 participants