Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intelligent polygon editing #1921

Merged
merged 4 commits into from
Jul 24, 2020
Merged

Intelligent polygon editing #1921

merged 4 commits into from
Jul 24, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jul 21, 2020

Motivation and context

Our internal team and the community asked us to simplify polygon editing to remove extra action, related with selection of a final polygon.

This PR introduces updated approach. Two criteria are computer to decide which part of a polygon should be cut during editing automatically. The first criteria is a number of cut points. The second criteria is a length of a cut curve. If both criteria recommend to cut the same part, algorithm works automatically, if not, a user asked to make a choice.

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Resolve #1579
Resolve #1515

@bsekachev bsekachev added the enhancement New feature or request label Jul 21, 2020
@bsekachev bsekachev added this to In progress in UI via automation Jul 21, 2020
@coveralls
Copy link

coveralls commented Jul 21, 2020

Pull Request Test Coverage Report for Build 6531

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 64.984%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 1 77.29%
Totals Coverage Status
Change from base Build 6516: -0.004%
Covered Lines: 11064
Relevant Lines: 16620

💛 - Coveralls

ActiveChooN
ActiveChooN previously approved these changes Jul 24, 2020
@bsekachev bsekachev requested a review from nmanovic as a code owner July 24, 2020 13:25
UI automation moved this from In progress to Review in progress Jul 24, 2020
@bsekachev bsekachev merged commit 1e2c826 into develop Jul 24, 2020
UI automation moved this from Review in progress to Done Jul 24, 2020
@bsekachev bsekachev deleted the bs/polygon_editing branch July 29, 2020 11:29
@rodo-qatar
Copy link

Is there any possibility to switch between the Intelligent polygon editing approach and the extra action approach?
I found specially annoying that I dont know in advance which part will be kept when splitting a polygon under the inteligent approach. Could this be disabled at request somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
UI
  
Done
Development

Successfully merging this pull request may close these issues.

Polygon editing behaviour can be unexpected CVAT new UI: polygon editing
4 participants