Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add https flag to python cli #1942

Merged
merged 3 commits into from
Jul 28, 2020
Merged

add https flag to python cli #1942

merged 3 commits into from
Jul 28, 2020

Conversation

ilouzl
Copy link
Contributor

@ilouzl ilouzl commented Jul 27, 2020 •
edited

Fix #1940

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@ilouzl ilouzl requested a review from azhavoro as a code owner July 27, 2020 15:11
@ilouzl ilouzl requested a review from nmanovic as a code owner July 27, 2020 15:12
@coveralls
Copy link

coveralls commented Jul 27, 2020 •
edited

Pull Request Test Coverage Report for Build 6607

  • 4 of 5 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 64.979%
Changes Missing Coverage Covered Lines Changed/Added Lines %
utils/cli/cli.py 0 1 0.0%
Totals Coverage Status
Change from base Build 6575: 0.03%
Covered Lines: 11090
Relevant Lines: 16660
💛 - Coveralls

nmanovic
nmanovic approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic
Copy link
Contributor

@azhavoro , could you please test and merge the PR?

@azhavoro azhavoro merged commit 7679434 into cvat-ai:develop Jul 28, 2020
@ilouzl ilouzl deleted the support-https-python-cli-#1940 branch July 28, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanovic nmanovic nmanovic approved these changes

@azhavoro azhavoro azhavoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI python utility doesn't support https connections
4 participants
@ilouzl @coveralls @nmanovic @azhavoro