Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running detectors on the fly #2102

Merged
merged 34 commits into from
Sep 4, 2020
Merged

Running detectors on the fly #2102

merged 34 commits into from
Sep 4, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Aug 31, 2020

Motivation and context

Our customers asked as to implement the feature that allows to annotate only one specific frame with automatic detectors
Resolve #197
The PR depends on #2054

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT
  • Show only detectors on annotation view
  • Add ability to cancel annotation request
  • Prettify UI

@bsekachev bsekachev added the enhancement New feature or request label Aug 31, 2020
@bsekachev bsekachev added this to In progress in UI via automation Aug 31, 2020
@bsekachev bsekachev changed the title [WIP] Running detectors on the fly [WIP] [Dependent] Running detectors on the fly Aug 31, 2020
@bsekachev bsekachev changed the title [WIP] [Dependent] Running detectors on the fly [Dependent] Running detectors on the fly Aug 31, 2020
@coveralls
Copy link

coveralls commented Sep 1, 2020

Pull Request Test Coverage Report for Build 7283

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.67%

Totals Coverage Status
Change from base Build 7280: 0.0%
Covered Lines: 12409
Relevant Lines: 17164

💛 - Coveralls

ActiveChooN
ActiveChooN previously approved these changes Sep 1, 2020
@bsekachev bsekachev changed the title [Dependent] Running detectors on the fly Running detectors on the fly Sep 1, 2020
UI automation moved this from In progress to Review in progress Sep 1, 2020
@nmanovic
Copy link
Contributor

nmanovic commented Sep 2, 2020

Please don't assume that if we map all labels from the task, it is enough. In general I can want to map multiple labels to one. For example, { car -> vehicle, bus -> vehicle, truck -> vehicle }.

Can we adjust labels by columns? The new version:
image

The dialog below looks much better in the old version:
image

@bsekachev
Copy link
Member Author

@nmanovic Sure. I will fix it.

@bsekachev
Copy link
Member Author

@nmanovic

Fixed comments.
Also looks like found the issue why server returns all detections (with labels that absent in mapping). The client didn't sent mapping to the server.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors for labels should be taken from the task itself. Now "person" each time has own random color.

UI automation moved this from Review in progress to Reviewer approved Sep 4, 2020
@nmanovic nmanovic merged commit bd14385 into develop Sep 4, 2020
UI automation moved this from Reviewer approved to Done Sep 4, 2020
@nmanovic nmanovic deleted the bs/on_the_fly_detection branch September 4, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
UI
  
Done
Development

Successfully merging this pull request may close these issues.

Support on-the-fly tensorflow inference
4 participants