Remove the Git repository synchronization functionality #6904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
force-pushed
the
remove-git-sync
branch
2 times, most recently
from
5acf843
to
9c9726f
Compare
|
/check |
|
❌ Some checks failed |
This functionality has accumulated significant technical debt: * Most importantly, it does not use the current authorization system, rendering it accessible only for admin users. * It doesn't follow the regular API conventions, and is not visible in the API schema. This necessitates special code in the SDK. * The initialization code in `base.py` is not safe when multiple instances of the server start at the same time (each instance may end up generating its own key). The team has decided that the cost of fixing these issues outweighs the benefit of the functionality, so remove it.
SpecLad
force-pushed
the
remove-git-sync
branch
from
9c9726f
to
69debdf
Compare
|
/check |
|
✔️ All checks completed successfully |
SpecLad
requested review from
azhavoro,
bsekachev,
mdacoca,
Marishka17 and
nmanovic
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6904 +/- ##
=========================================
Coverage 82.52% 82.52%
=========================================
Files 370 360 -10
Lines 39869 38908 -961
Branches 3560 3544 -16
=========================================
- Hits 32902 32110 -792
+ Misses 6967 6798 -169
|
This was referenced Oct 2, 2023
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
This functionality has accumulated significant technical debt: * Most importantly, it does not use the current authorization system, rendering it accessible only for admin users. * It doesn't follow the regular API conventions and is not visible in the API schema. This necessitates a special code in the SDK. * The initialization code in `base.py` is not safe when multiple instances of the server starts at the same time (each instance may end up generating its own key). The team has decided that the cost of fixing these issues outweighs the benefit of the functionality, so remove it.
|
Hello! |
|
@PMazarovich , you are the only known user of the feature. Could you please describe how have you used the feature? |
|
@nmanovic here it is:
|
Closed
2 tasks
|
IMHO it was a nice automatic backup feature and I would prefer it to other methods like manually created backups by admins or even users. I understand your decision "cost of fixing vs. benefit of functionality" but nevertheless it was a useful feature and I would vote for it. :-) |
Can it be implemented using web hooks? https://opencv.github.io/cvat/docs/administration/advanced/webhooks/ |
2 tasks
2 tasks
nmanovic
pushed a commit
that referenced
this pull request
Mar 22, 2024
This was only used by the Git synchronization functionality, which was removed in #6904.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This functionality has accumulated significant technical debt:
Most importantly, it does not use the current authorization system,
rendering it accessible only for admin users.
It doesn't follow the regular API conventions, and is not visible in the API
schema. This necessitates special code in the SDK.
The initialization code in
base.pyis not safe when multiple instances ofthe server start at the same time (each instance may end up generating its
own key).
The team has decided that the cost of fixing these issues outweighs the benefit
of the functionality, so remove it.
How has this been tested?
Checklist
developbranch[ ] I have linked related issues (see GitHub docs)(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.