Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved issues comments pipeline #6937

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Improved issues comments pipeline #6937

merged 7 commits into from
Oct 5, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Oct 4, 2023

Motivation and context

image

  • The latest comment shown in the sidebar
  • Added ability to copy comments content
  • Fixed some inconvenient behavior when canvas fit/moved or context menu for a shape opened when user acts on issue dialog
  • Fixed blur effect appearing in some cases by changing css rules

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested review from klakhov and azhavoro and removed request for mdacoca October 4, 2023 07:46
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #6937 (d649d1c) into develop (0be063e) will increase coverage by 0.02%.
Report is 4 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #6937      +/-   ##
===========================================
+ Coverage    82.59%   82.62%   +0.02%     
===========================================
  Files          360      360              
  Lines        38868    38867       -1     
  Branches      3544     3544              
===========================================
+ Hits         32104    32113       +9     
+ Misses        6764     6754      -10     
Components Coverage Δ
cvat-ui 77.66% <100.00%> (+0.03%) ⬆️
cvat-server 87.15% <ø> (+0.01%) ⬆️

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding a colon after username like that:
image

@bsekachev bsekachev merged commit bfc86ae into develop Oct 5, 2023
33 checks passed
@azhavoro azhavoro mentioned this pull request Oct 6, 2023
@bsekachev bsekachev deleted the bs/reversed_comments branch October 9, 2023 12:45
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants