Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist image filters across jobs #6953

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Persist image filters across jobs #6953

merged 6 commits into from
Oct 10, 2023

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Oct 6, 2023

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov added enhancement New feature or request ui/ux labels Oct 6, 2023
@klakhov klakhov requested a review from nmanovic as a code owner October 6, 2023 12:54
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #6953 (8bba886) into develop (ae1dc1b) will decrease coverage by 0.02%.
Report is 9 commits behind head on develop.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop    #6953      +/-   ##
===========================================
- Coverage    82.59%   82.58%   -0.02%     
===========================================
  Files          360      360              
  Lines        38867    38924      +57     
  Branches      3544     3570      +26     
===========================================
+ Hits         32104    32144      +40     
- Misses        6763     6780      +17     
Components Coverage Δ
cvat-ui 77.61% <77.04%> (-0.03%) ⬇️
cvat-server 87.13% <100.00%> (ø)

@klakhov klakhov merged commit 6ce88d3 into develop Oct 10, 2023
33 checks passed
@klakhov klakhov deleted the kl/persist-image-filters branch October 11, 2023 09:29
This was referenced Oct 11, 2023
@cvat-bot cvat-bot bot mentioned this pull request Oct 12, 2023
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui/ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants