Fix tracks splitting for tracks that have sub-tracks #6968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6968 +/- ##
========================================
Coverage 82.58% 82.58%
========================================
Files 360 360
Lines 38914 38923 +9
Branches 3570 3570
========================================
+ Hits 32137 32146 +9
Misses 6777 6777
|
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
When uploading annotations for the whole task that has few jobs our server splits tracks. Each track we divide into a few tracks in that way that each track corresponds to only one job and all shapes of the track do not extend beyond the frame range corresponding to that job. It mainly works, but we have a problem with skeleton tracks. Due to this problem we if upload skeleton tracks for the whole task all our tracks will be duplicated for each job but not split, it means that we will have tracks that extend beyond the frame range of jobs and it leads to bad side effects, in this case, our exported annotations from such task could be incorrect or we won't be able to export annotations at all. And the reason for this problem is this small bug, which this PR fixes. Our code really slices sub-tracks for the skeleton track, but after this slicing server doesn't save the result.
6 tasks
zhiltsov-max
added a commit
that referenced
this pull request
Mar 28, 2024
Fixes #7498 In #6968, sub tracks splitting has been fixed but not entirely, if the user wants to import tracks between more than 2 jobs it can cause malformed annotation like #7498. In the pervious test case, https://github.com/opencv/cvat/blob/d1a300f0189744bef01d2c60135ec474c5004fbc/tests/python/rest_api/test_tasks.py#L543-L563 skeleton track is static so it did not identify any issues. <!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context Pervious interpolate method will drop the last frame. That's correct for most cases, but if slices and tracks are like this: slice: -------------xxxxx--------- track: ---------xxxxxxxxxx------- We have to keep the last frame of slice in the track. If not, this track won't close. ### How has this been tested? I rewrited the testcase `test_can_split_skeleton_tracks_on_jobs` Now it test the split function with a longer input track and stricter interpolate reference. ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> ~~- [ ] I have updated the documentation accordingly~~ - [x] I have added tests to cover my changes - [x] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [x] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. --------- Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
g-kartik
pushed a commit
to g-kartik/cvat
that referenced
this pull request
Mar 29, 2024
Fixes cvat-ai#7498 In cvat-ai#6968, sub tracks splitting has been fixed but not entirely, if the user wants to import tracks between more than 2 jobs it can cause malformed annotation like cvat-ai#7498. In the pervious test case, https://github.com/opencv/cvat/blob/d1a300f0189744bef01d2c60135ec474c5004fbc/tests/python/rest_api/test_tasks.py#L543-L563 skeleton track is static so it did not identify any issues. <!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context Pervious interpolate method will drop the last frame. That's correct for most cases, but if slices and tracks are like this: slice: -------------xxxxx--------- track: ---------xxxxxxxxxx------- We have to keep the last frame of slice in the track. If not, this track won't close. ### How has this been tested? I rewrited the testcase `test_can_split_skeleton_tracks_on_jobs` Now it test the split function with a longer input track and stricter interpolate reference. ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> ~~- [ ] I have updated the documentation accordingly~~ - [x] I have added tests to cover my changes - [x] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [x] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. --------- Co-authored-by: Maxim Zhiltsov <zhiltsov.max35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
When uploading annotations for the whole task that has few jobs our server splits tracks. Each track we divide into a few tracks in that way that each track corresponds to only one job and all shapes of the track do not extend beyond the frame range corresponding to that job.
It mainly works, but we have a problem with skeleton tracks. Due to this problem we if upload skeleton tracks for the whole task all our tracks will be duplicated for each job but not split, it means that we will have tracks that extend beyond the frame range of jobs and it leads to bad side effects, in this case, our exported annotations from such task could be incorrect or we won't be able to export annotations at all.
And the reason for this problem is this small bug, which this PR fixes. Our code really slices sub-tracks for the skeleton track, but after this slicing server doesn't save the result.
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.