Allow to upload tracks from COCO formats #6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sizov-kirill
changed the title
nmanovic
reviewed
Oct 11, 2023
nmanovic
reviewed
Oct 11, 2023
tests/python/rest_api/test_tasks.py
Outdated
| task.import_annotations(format_name, dataset_file) | ||
|
|
||
| imported_annotations = task.get_annotations() | ||
| print(imported_annotations) |
Codecov Report
@@ Coverage Diff @@
## develop #6969 +/- ##
===========================================
+ Coverage 82.58% 82.59% +0.01%
===========================================
Files 360 360
Lines 38914 38928 +14
Branches 3570 3570
===========================================
+ Hits 32137 32154 +17
+ Misses 6777 6774 -3
|
nmanovic
approved these changes
Oct 12, 2023
Merged
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
This PR resolves the following problems:
1. During import we ignore track_id attribute for annotations if these
annotations do not come from one of these formats `('cvat', 'datumaro',
'sly_pointcloud')` this prevents to import tracks in coco format -> this
PR extends the list of "track formats"
2. When we convert a dataset from CVAT representation to Datumaro
Dataset in all possible situations only the first shape of the skeleton
track is a keyframe, all other shapes will be as marked as not keyframes
it leads to problems when we try to import such tracks that were
exported from CVAT -> this PR adds the following line of code: set
`keyframe = True` for skeletons if at least one point of this skeleton
is keyframe
3. During import skeleton tracks our code always expects to see a
"keyframe" attribute for the skeleton's element, but not all formats
support attributes for skeleton points (for example COCO Keypoints
doesn't allow to have attributes for each skeleton's point). And if the
server doesn't see this attribute for some element we ignore this
element -> this PR adds the following logic for skeleton track: if
skeleton's elements don't have a keyframe attribute at all then consider
such skeleton elements as keyframes = True
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR resolves the following problems:
('cvat', 'datumaro', 'sly_pointcloud')this prevents to import tracks in coco format -> this PR extends the list of "track formats"keyframe = Truefor skeletons if at least one point of this skeleton is keyframeHow has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.