Enabled nginx proxy buffering #6991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azhavoro
force-pushed
the
az/update_nginx_config
branch
from
8c040c0
to
39145db
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6991 +/- ##
===========================================
+ Coverage 82.59% 82.60% +0.01%
===========================================
Files 360 360
Lines 38926 38920 -6
Branches 3570 3570
===========================================
+ Hits 32150 32151 +1
+ Misses 6776 6769 -7
|
nmanovic
approved these changes
Oct 12, 2023
| @@ -73,7 +73,8 @@ http { | |||
| proxy_set_header Upgrade $http_upgrade; | |||
| proxy_set_header Connection $connection_upgrade; | |||
| proxy_redirect off; | |||
| proxy_buffering off; | |||
There was a problem hiding this comment.
cvat/nginx.conf
Outdated
| @@ -73,7 +73,8 @@ http { | |||
| proxy_set_header Upgrade $http_upgrade; | |||
| proxy_set_header Connection $connection_upgrade; | |||
| proxy_redirect off; | |||
| proxy_buffering off; | |||
| proxy_buffering on; | |||
| proxy_buffers 100 512k; | |||
There was a problem hiding this comment.
Need to explain values and probably leave comments on why they chose them.
I like a reply in the thread: https://stackoverflow.com/questions/33460569/nginx-proxy-buffering-changing-buffers-number-vs-size
"There's likely a good reason that the default number of buffers was chosen to be 8 as well."
Merged
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.