Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant memory optimization when working with masks #6996

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Oct 12, 2023

Motivation and context

Snapshot 5 after playing the frames twice before the patch
Snapshot 6 after playing the frames twice after the patch
image

Resolved #6994

TODO:

  • Check models/interactors
  • Check remove underlying pixels

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev changed the title [WIP] Significant memory optimization when working with masks Significant memory optimization when working with masks Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #6996 (631c78d) into develop (b450b44) will decrease coverage by 0.06%.
Report is 10 commits behind head on develop.
The diff coverage is 87.78%.

@@             Coverage Diff             @@
##           develop    #6996      +/-   ##
===========================================
- Coverage    82.59%   82.53%   -0.06%     
===========================================
  Files          360      360              
  Lines        38926    38977      +51     
  Branches      3570     3577       +7     
===========================================
+ Hits         32150    32171      +21     
- Misses        6776     6806      +30     
Components Coverage Δ
cvat-ui 77.51% <87.78%> (-0.10%) ⬇️
cvat-server 87.16% <ø> (-0.01%) ⬇️

@bsekachev bsekachev merged commit 80e20ff into develop Oct 13, 2023
33 checks passed
@nmanovic nmanovic deleted the bs/optimize_masks branch October 13, 2023 11:49
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize working with points in masks
2 participants