Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCS] Skip manually created dirs #7006

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Oct 13, 2023

Motivation and context

The same problem for GCS as was fixed for AWS S3 #6997

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
    - [ ] I have updated the documentation accordingly
    - [ ] I have added tests to cover my changes
    - [ ] I have linked related issues (see GitHub docs)
    - [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@azhavoro
Copy link
Contributor

Please add an entry to the changelog

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #7006 (243912c) into develop (b450b44) will decrease coverage by 0.28%.
Report is 20 commits behind head on develop.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           develop    #7006      +/-   ##
===========================================
- Coverage    82.59%   82.32%   -0.28%     
===========================================
  Files          360      361       +1     
  Lines        38926    39168     +242     
  Branches      3570     3586      +16     
===========================================
+ Hits         32150    32244      +94     
- Misses        6776     6924     +148     
Components Coverage Δ
cvat-ui 77.28% <100.00%> (-0.33%) ⬇️
cvat-server 86.95% <0.00%> (-0.21%) ⬇️

@azhavoro azhavoro self-requested a review October 16, 2023 14:28
@azhavoro azhavoro merged commit b7ea8d1 into develop Oct 16, 2023
33 checks passed
@bsekachev bsekachev deleted the mk/gcs_skip_manually_created_dirs branch October 20, 2023 12:31
@cvat-bot cvat-bot bot mentioned this pull request Oct 23, 2023
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
The same problem for GCS as was fixed for AWS S3
cvat-ai#6997
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
~~- [ ] I have updated the documentation accordingly~~
~~- [ ] I have added tests to cover my changes~~
~~- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~
~~- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))~~

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants