Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running CVAT with an external database via Docker Compose #7055

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Oct 24, 2023

Motivation and context

This would help users who don't want or need the complexity of Kubernetes, but would still like to use an external database.

With Docker Compose, you can initialize a secret from an environment variable, but you can't load a secret into an environment variable. So in order to be able to read the DB password from a secret, I had to introduce a new CVAT_POSTGRES_PASSWORD_FILE variable.

How has this been tested?

Manual testing.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

With Docker Compose, you can initialize a secret from an environment
variable, but you can't load a secret _into_ an environment variable. So in
order to be able to read the DB password from a secret, I had to introduce a
new `CVAT_DB_PASSWORD_FILE` variable.
@SpecLad SpecLad force-pushed the docker-compose-external-db branch 2 times, most recently from 13f1f7e to 25e4ce6 Compare October 24, 2023 16:33
@SpecLad SpecLad marked this pull request as ready for review October 24, 2023 16:41
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #7055 (25e4ce6) into develop (c6682ff) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #7055      +/-   ##
===========================================
- Coverage    82.33%   82.29%   -0.05%     
===========================================
  Files          361      361              
  Lines        39213    39213              
  Branches      3585     3585              
===========================================
- Hits         32286    32270      -16     
- Misses        6927     6943      +16     
Components Coverage Δ
cvat-ui 77.27% <ø> (-0.09%) ⬇️
cvat-server 86.90% <ø> (ø)

@nmanovic nmanovic merged commit 08550f8 into cvat-ai:develop Oct 26, 2023
42 checks passed
@cvat-bot cvat-bot bot mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants