Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple changing job state #7158

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 21, 2023

Motivation and context

403 code when updating job state many times. Steps to reproduce:

  1. Open a job from Supervisor user in an organization
  2. Change job state to any other >> Works.
  3. Change job state one more time >> 403 code.
  4. Reload the page, change job state again >> Works.

How has this been tested?

Manually

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev changed the title [WIP] Fixed multiple changing job state Fixed multiple changing job state Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #7158 (1934db5) into develop (a9a98b3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7158   +/-   ##
========================================
  Coverage    81.40%   81.41%           
========================================
  Files          364      364           
  Lines        39904    39910    +6     
  Branches      3699     3702    +3     
========================================
+ Hits         32485    32491    +6     
  Misses        7419     7419           
Components Coverage Δ
cvat-ui 75.49% <100.00%> (+0.01%) ⬆️
cvat-server 86.94% <ø> (-0.01%) ⬇️

@bsekachev bsekachev merged commit bb579e8 into develop Nov 22, 2023
34 checks passed
@cvat-bot cvat-bot bot mentioned this pull request Nov 22, 2023
@bsekachev bsekachev deleted the bs/fixed_multiple_changing_job_state branch November 23, 2023 07:48
@cvat-bot cvat-bot bot mentioned this pull request Nov 23, 2023
@bsekachev bsekachev mentioned this pull request Dec 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants