Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Allow pre-release k8s versions to fix AWS EKS deployments #7183

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

ozen
Copy link
Contributor

@ozen ozen commented Nov 25, 2023

Fixes #7182 by including pre-release versions as explained in the helm docs.

@ozen ozen requested a review from azhavoro as a code owner November 25, 2023 21:07
@ozen ozen changed the title Allow pre-release k8s versions in Chart.yaml to fix AWS EKS deployments [Helm] Allow pre-release k8s versions to fix AWS EKS deployments Nov 26, 2023
@SpecLad
Copy link
Contributor

SpecLad commented Nov 28, 2023

Thanks, looks good to me. Would you mind adding a changelog entry?

@ozen ozen force-pushed the fix/helm-chart-kube-version branch from c9a09ac to cef7c39 Compare November 29, 2023 08:32
@ozen ozen requested a review from nmanovic as a code owner November 29, 2023 08:32
@ozen
Copy link
Contributor Author

ozen commented Nov 29, 2023

Thanks, looks good to me. Would you mind adding a changelog entry?

Thanks. Added changelog entry.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #7183 (694466f) into develop (81da411) will increase coverage by 0.01%.
Report is 7 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7183      +/-   ##
===========================================
+ Coverage    81.48%   81.49%   +0.01%     
===========================================
  Files          364      365       +1     
  Lines        39883    39923      +40     
  Branches      3702     3703       +1     
===========================================
+ Hits         32499    32537      +38     
- Misses        7384     7386       +2     
Components Coverage Δ
cvat-ui 75.53% <ø> (+0.03%) ⬆️
cvat-server 87.09% <ø> (-0.01%) ⬇️

@SpecLad
Copy link
Contributor

SpecLad commented Dec 1, 2023

There is a remark issue, could you fix it?

@SpecLad SpecLad merged commit de4d4c1 into cvat-ai:develop Dec 1, 2023
34 checks passed
@ozen ozen deleted the fix/helm-chart-kube-version branch December 1, 2023 15:02
@cvat-bot cvat-bot bot mentioned this pull request Dec 11, 2023
amjadsaadeh pushed a commit to amjadsaadeh/cvat that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart's kubeVersion constraint prevents deployments to AWS EKS
2 participants