Fix opacity reset #7186
Merged
Fix opacity reset #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
reviewed
Nov 27, 2023
2 tasks
|
Changelog? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7186 +/- ##
===========================================
- Coverage 81.48% 81.44% -0.05%
===========================================
Files 364 365 +1
Lines 39877 39886 +9
Branches 3702 3700 -2
===========================================
- Hits 32494 32484 -10
- Misses 7383 7402 +19
|
bsekachev
previously approved these changes
Nov 28, 2023
|
Now there is one more issue, when I navigate from a frame without masks to frame with masks, opacity keeps on low level and masks are not visible
|
bsekachev
reviewed
Nov 28, 2023
cvat-ui/src/utils/clamp-opacity.ts
Outdated
Comment on lines
18
to
23
| const withMasks = states | ||
| .some((_state: ObjectState): boolean => _state.shapeType === ShapeType.MASK); | ||
| const opacity = withMasks || job?.dimension === DimensionType.DIMENSION_3D ? | ||
| Math.max(shapes.opacity, ENHANCED_DEFAULT_OPACITY) : shapes.opacity; | ||
| const selectedOpacity = withMasks || job?.dimension === DimensionType.DIMENSION_3D ? | ||
| Math.max(shapes.selectedOpacity, ENHANCED_DEFAULT_SELECTED_OPACITY) : shapes.selectedOpacity; |
There was a problem hiding this comment.
As an optimization, I would suggest first to check if current opacity/selected opacity already more or equal than enhanced level, just skip the algorithm. Also checking job?.dimension is quicker, so, it is a thing we should probably do first
bsekachev
approved these changes
Nov 29, 2023
Merged
amjadsaadeh
pushed a commit
to amjadsaadeh/cvat
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolved #7176
Opacity keeps resetting after changing frame (even without the masks)
How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.