Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a 'validate_plugin.py' spec and document it in the OpenVisionCapsules Readme #4

Open
apockill opened this issue Jan 30, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@apockill
Copy link
Collaborator

It should using the vcap.testing utilities.

@apockill apockill added the enhancement New feature or request label Jan 30, 2020
@apockill apockill self-assigned this Jan 30, 2020
@sanketsans
Copy link

@apockill Have you been working on this issue ? I want to start working on it. Some headups will also be good.

@apockill
Copy link
Collaborator Author

apockill commented Nov 18, 2020

Hi sanketsan,

Thank you for reaching out and offering to contribute! I haven't been working on this particular issue, so help is always appreciated.

Here's what we would want:

  1. A script under tools/verify_capsule_spec/main.py

  2. You should be able to pass in a packaged or unpackaged capsule, and it should run verification tests on it. Example usage of the application:
    tools/verify_capsule_spec/main.py --capsule CAPSULE.cap --images-dir /path/to/directory/with/images or tools/verify_capsule_spec/main.py --capsule CAPSULE/ --images-dir /path/to/directory/with/images

  3. Example output of what we might expect from this script

Loading Capsule {capsule path}
Running Capsule Verification Tests:
Running Inference on {# of images} stored in {image directory path}

Verification tests complete! Your capsule performs as expected.

If a traceback happens, it should catch it and print it back using a formatted traceback (maybe using `traceback.format_exc())), and the application should exit with a non-zero exit code.

  1. Internally, the script should be essentially running the test utility written under the vcap.testing.perform_capsule_tests function, and passing in all of the images stored in that directory.

@Vardhan-Kaashikar
Copy link
Contributor

Hey @apockill can I work on this issue?

@apockill
Copy link
Collaborator Author

apockill commented Jan 8, 2023

Absolutely, anyone is free to work on this feature.

@Vardhan-Kaashikar
Copy link
Contributor

Hey I was just trying to make use of the example capsules as given in the Readme.md file and came across a common error in most of the files, where we are fetching functions from other files but since vcap folder has a sub folder named "vcap" which is not being added while fetching functions it is causing errors (for example: "vcap.node_description" is being searcher instead of "vcap.vcap.node_description" as shown in the screenshot below), should I fix all the files and then start with this issue?

Also am I heading in the right direction?
opencv error

@Vardhan-Kaashikar
Copy link
Contributor

Hey @apockill should I continue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants