Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need throw matches with high confidence in BestOf2NearestMatcher? #11084

Closed
xdumengyu opened this issue Mar 15, 2018 · 0 comments · Fixed by #22505
Closed

Do we need throw matches with high confidence in BestOf2NearestMatcher? #11084

xdumengyu opened this issue Mar 15, 2018 · 0 comments · Fixed by #22505

Comments

@xdumengyu
Copy link

I found in line in BestOf2NearestMatcher, high confidence matches are set to zero confidence,
I also notice that in line in AffineBestOf2NearestMatcher, the line is commented.

In my experiment, I found with high confidence matches setting to zero, I lost some adjacent pictures, which overlap over 40%, which leads to blank in my final result. When I calculated the confidence outside the function and set the confidence > 3.0 's match to its actual value, I got correct result. And I suggest to comment the line line in BestOf2NearestMatcher
Is there anybody have same experience with me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants