Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recurrent layers of dnn module] fully support to LSTM and GRU is needed #19278

Closed
3 of 4 tasks
HannibalAPE opened this issue Jan 7, 2021 · 5 comments
Closed
3 of 4 tasks
Assignees
Labels
category: dnn (onnx) ONNX suport issues in DNN module category: dnn feature
Milestone

Comments

@HannibalAPE
Copy link
Contributor

HannibalAPE commented Jan 7, 2021

System information (version)
  • OpenCV => 4.5
  • Operating System / Platform => Ubuntu 20.04
  • Compiler => ❔
Detailed description
  1. Currently, the LSTM of ONNX importer can not support the non-zero inputs of hidden state and cell state.

    CV_CheckEQ(countNonZero(getBlob(node_proto, 5)), 0, "Unsupported non zero initial_h");

    CV_CheckEQ(countNonZero(getBlob(node_proto, 6)), 0, "Unsupported non zero initial_c");

  2. ONNX importer can not support GRU layer.
    When can this layer be added to the ONNX importer?
    It also needs to support the non-zero inputs of the hidden state.

These features are needed in the state-of-the-art methods of Text Recognition.
Thank you in advance!

Issue submission checklist
  • I report the issue, it's not a question
  • I checked the problem with documentation, FAQ, open issues,
    answers.opencv.org, Stack Overflow, etc and have not found solution
  • I updated to latest OpenCV version and the issue is still there
  • There is reproducer code and related data files: videos, images, onnx, etc
@JulieBar
Copy link
Contributor

@HannibalAPE it should work now. Please try latest build

@JulieBar JulieBar removed their assignment Nov 21, 2021
@asmorkalov
Copy link
Contributor

@HannibalAPE Friendly reminder.

@asmorkalov asmorkalov added the category: dnn (onnx) ONNX suport issues in DNN module label Dec 9, 2021
@HannibalAPE
Copy link
Contributor Author

@JulieBar @asmorkalov Thanks a lot. We will use them to build some modern text recognition networks.

@asmorkalov
Copy link
Contributor

#23475

@asmorkalov
Copy link
Contributor

#23501

@asmorkalov asmorkalov added this to the 4.8.0 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: dnn (onnx) ONNX suport issues in DNN module category: dnn feature
Projects
None yet
Development

No branches or pull requests

6 participants