Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts about HOGDescriptor related to OpenCV 5 #22129

Open
sturkmen72 opened this issue Jun 19, 2022 · 1 comment
Open

Thoughts about HOGDescriptor related to OpenCV 5 #22129

sturkmen72 opened this issue Jun 19, 2022 · 1 comment

Comments

@sturkmen72
Copy link
Contributor

Detailed description

recently i used cv2.HOGDescriptor() in pyhton and the following ideas came to my mind

  1. HOGDescriptor is implemented as struct i think it could be re-implemented as class
    this will solve documentation issues about it ( currently no python usage of methods showed in the documentation).
    also solves the following issue:
    hog = cv2.HOGDescriptor() ( equal to hog = cv2.HOGDescriptor((64, 128), (16, 16), (8, 8), (8, 8), 9)) works.
    hog = cv2.HOGDescriptor((64, 128), (16, 16), (8, 8), (8, 8), 9) works
    hog = cv2.HOGDescriptor((64, 128)) raises an error. ( for giving a new value to one parameter we need give values to other parameters even they have default values )

  2. it is possible to drop getDefaultPeopleDetector() and getDaimlerPeopleDetector() functions. we can save their values into files like haarcascade files and hog.load() method is enough to load them.

  3. Some of the parameters not used at all in the implementation can be cleaned up.

i can work on this if the ideas in general sound good.

@asmorkalov
Copy link
Contributor

/cc @vpisarev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants