Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM modules should not be stored as Base64 #22530

Closed
4 tasks done
KOLANICH opened this issue Sep 18, 2022 · 2 comments · Fixed by #23344
Closed
4 tasks done

WASM modules should not be stored as Base64 #22530

KOLANICH opened this issue Sep 18, 2022 · 2 comments · Fixed by #23344

Comments

@KOLANICH
Copy link
Contributor

Detailed description

Base64 is bloat.

Steps to reproduce
  1. Download https://docs.opencv.org/5.x/opencv.js
  2. Open in a text editor
  3. See base-64 encoded WASM module.
Issue submission checklist
  • I report the issue, it's not a question
  • I checked the problem with documentation, FAQ, open issues,
    forum.opencv.org, Stack Overflow, etc and have not found any solution
  • I updated to the latest OpenCV version and the issue is still there
  • There is reproducer and related data files: videos, images, onnx, etc
@asmorkalov
Copy link
Contributor

It looks like base64 comes from this line (-s SINGLE_FILE=1): https://github.com/opencv/opencv/blob/4.x/modules/js/CMakeLists.txt#L73

@KOLANICH
Copy link
Contributor Author

Thanks.

@asmorkalov asmorkalov added this to the 4.8.0 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants