Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highgui: wayland: show "NO" status if dependency is missing #25496

Merged
merged 5 commits into from Apr 29, 2024
Merged

highgui: wayland: show "NO" status if dependency is missing #25496

merged 5 commits into from Apr 29, 2024

Conversation

Kumataro
Copy link
Contributor

Close #25495

  • [doc] Add document to enable Wayland highgui-backend in ubuntu 24.04.
  • [build] Show "NO" status instead of version if dependency library is missing.
  • [build] Fix to find Wayland EGL.
  • [fix] Add some callback stub functions to suppress build warning.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Kumataro
highgui: wayland: show "NO" status if dependency is missing
f8c4eb9 
- [doc] Add document to enable Wayland highgui-backend in ubuntu 24.04.
- [build] Show "NO" status instead of version if dependency library is missing.
- [build] Fix to find Wayland EGL.
- [fix] Add some callback stub functions to suppress build warning.
@Kumataro
remove new blank line at EOF
4620913
@opencv-alalek opencv-alalek added this to the 4.10.0 milestone Apr 27, 2024
asmorkalov
asmorkalov approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested with Kubuntu 24.04 with Wayland session.

@asmorkalov asmorkalov self-assigned this Apr 29, 2024
@asmorkalov asmorkalov merged commit 2a2ff55 into opencv:4.x Apr 29, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opencv-alalek opencv-alalek opencv-alalek left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels
category: build/install category: documentation Documentation fix or update category: highgui-gui
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

highgui: wayland: if dependency is missing, "NO" message will help to install them.
3 participants
@Kumataro @asmorkalov @opencv-alalek