Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aruco: completed wrapping for Python bindings #554

Merged
merged 1 commit into from May 20, 2016

Conversation

cr333
Copy link
Contributor

@cr333 cr333 commented Feb 18, 2016

No description provided.

@paroj
Copy link
Contributor

paroj commented Mar 10, 2016

👍

@adrianheron
Copy link
Contributor

I was using the aruco bindings in your branch (thank you!) and encountered an issue with the estimatePoseSingleMarkers function. I've tried to describe it here #574

@cr333
Copy link
Contributor Author

cr333 commented Mar 22, 2016

The bindings for estimatePoseSingleMarkers already existed before my changes, and I didn't try them myself.

@jfolz
Copy link
Contributor

jfolz commented Mar 28, 2016

@cr333 Good job on finding all the stuff that I missed!
One question: Do the Dictionary properties still work with CV_PROP instead of CV_PROP_RW? I encountered some problems with accessibility from Python using the former.
I have also yet to find a good explanation for how they differ. Maybe you know more?

@cr333
Copy link
Contributor Author

cr333 commented Mar 28, 2016

@jfolz Sorry, I'm not really familiar with the internals of the wrapping process either. My reference was http://docs.opencv.org/3.1.0/da/d49/tutorial_py_bindings_basics.html

It suggests that CV_PROP is used for fields of classes wrapped with CV_EXPORTS_W, and CV_PROP_RW for CV_EXPORTS_W_SIMPLE (small classes passed by value) or CV_EXPORTS_W_MAP (wrapped as dictionary), which is the case you're interested in.

@jfolz
Copy link
Contributor

jfolz commented Mar 29, 2016

@cr333 Yes, that's my source as well and I find the explanation a bit lacking. Looking at the parser and generator code suggests that there is exactly one difference: CP_PROP_RW creates a writeable property and CV_PROP does not. You most likely don't need writeable properties for the Dictionary in Python, Java etc., but its properties are public in C++, so why not?

@paroj
Copy link
Contributor

paroj commented Apr 5, 2016

@alalek

@mshabunin mshabunin self-assigned this May 20, 2016
@mshabunin
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants