Breaking changes in upcoming datacube-core release

[tom-butler]

• datacube-wms version: latest
• datacube-core version: develop 21/02/19

• new_datasource()

Unexpected server error: new_datasource() takes 1 positional argument but 2 were given

as per: https://datacube-core.readthedocs.io/en/latest/_modules/datacube/api/core.html?highlight=new_datasource

new data source only takes one argument, type: datacube.storage.BandInfo

• RasterDatasetDataSource

Unexpected server error: 'RasterDatasetDataSource' object has no attribute '_dataset'

After fixing the new_datasource call above, it's become apparent that the returned object has changed, It no longer has _dataset.id as an available parameter.

datasources = sorted(datasources, key=lambda x: x._dataset.id)

These issues will need to be fixed when the WMS is updated to use the next version of core

[tom-butler]

After fixing the new_datasource issue, it looks like there are a few more breaking changes I'll make this ticket more general as a catch-all for the new datacube-core release.