Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BenchmarkContext dataclass and benchmark data loading helpers #20

Merged
merged 9 commits into from Dec 1, 2021

Conversation

Kirill888
Copy link
Member

@Kirill888 Kirill888 commented Nov 30, 2021

Captures important context about benchmarking tasks and provides some reporting
facilities for that data.

I have added docs for odc.stac.bench.* too, but there are some issues with dataclasss and auto-type-hints in sphinx. Would be nice to figure out how to turn off documentation for autogenerated __init__ method.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #20 (700c7c4) into develop (1bf78d2) will increase coverage by 1.41%.
The diff coverage is 97.80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #20      +/-   ##
===========================================
+ Coverage    90.63%   92.04%   +1.41%     
===========================================
  Files           11       12       +1     
  Lines          737      918     +181     
===========================================
+ Hits           668      845     +177     
- Misses          69       73       +4     
Impacted Files Coverage Δ
odc/stac/bench.py 97.77% <97.77%> (ø)
odc/stac/_eo3.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf78d2...700c7c4. Read the comment docs.

@github-actions
Copy link

Captures important context about benchmarking tasks and provides some reporting
facilities for that data.
@github-actions
Copy link

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

@Kirill888 Kirill888 marked this pull request as ready for review December 1, 2021 01:22
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

@Kirill888 Kirill888 merged commit 1209a4e into develop Dec 1, 2021
@Kirill888 Kirill888 deleted the bench branch December 1, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants