Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORY] Split caikit/TGIS ServingRuntime into three distinct images #11

Closed
Xaenalt opened this issue Aug 25, 2023 · 16 comments
Closed

[STORY] Split caikit/TGIS ServingRuntime into three distinct images #11

Xaenalt opened this issue Aug 25, 2023 · 16 comments
Assignees
Labels
kind/feature New feature req From the Requirements document rhods-2.5

Comments

@Xaenalt
Copy link

Xaenalt commented Aug 25, 2023

From req doc:

P0: OOTB support Caikit/TGIS

  • 3 separate options - need to doc differences: caikit+tgis (current), caikit, tgis
  • Can only be enabled if KServe is enabled

Caikit+TGIS:

TGIS standalone:

Caikit:

@heyselbi heyselbi changed the title Split caikit/TGIS image into two distinct images [P0] Split caikit/TGIS image into three distinct images Sep 14, 2023
@heyselbi heyselbi added req From the Requirements document and removed req From the Requirements document labels Sep 14, 2023
@heyselbi heyselbi changed the title [P0] Split caikit/TGIS image into three distinct images Split caikit/TGIS image into three distinct images Oct 11, 2023
@dtrifiro
Copy link

dtrifiro commented Oct 11, 2023

Progress:

  • Caikit standalone image
  • sample manifests for kserve InferenceService and ServingRuntime
  • Proper TGIS/caikit containers networking

@dtrifiro
Copy link

Related to caikit-standalone image (without tgis backend):

caikit/caikit-nlp#210

@dtrifiro
Copy link

@heyselbi
Copy link

caikit/caikit-nlp#216

@bdattoma
Copy link

@Xaenalt could you share how to use the 3 options? even if doc is not completed, maybe you could share some instructions internally. Thanks!

@dtrifiro
Copy link

@bdattoma the idea is to have the options reported here opendatahub-io/caikit-tgis-serving#121. Feel free to reach out if you need more information. Hopefully I will have a PR ready in the next few hours

@bdattoma
Copy link

@bdattoma the idea is to have the options reported here opendatahub-io/caikit-tgis-serving#121. Feel free to reach out if you need more information. Hopefully I will have a PR ready in the next few hours

okay thank you. I'll wait for your PR :)

@heyselbi
Copy link

heyselbi commented Oct 26, 2023

Caikit standalone image available at caikit/caikit-nlp#244

@dtrifiro
Copy link

dtrifiro commented Oct 26, 2023

@bdattoma it seems that the above issue I linked above does need a few requirements such as the above PR before being actionable, so you'll have to wait some more time 😅

@heyselbi
Copy link

heyselbi commented Nov 6, 2023

Follow up issue on OOTB inclusion of all images in RHODS: #17

@bdattoma
Copy link

@Xaenalt for tracking purposes, could you edit this Issue saying explicitly that the only scenario covered was the Caikit+TGIS? by reading at it it looks like this issue covered also standalone Caikit and standalone TGIS

@heyselbi heyselbi changed the title Split caikit/TGIS image into three distinct images Split caikit/TGIS ServingRuntime into three distinct images Nov 15, 2023
@Xaenalt
Copy link
Author

Xaenalt commented Nov 16, 2023

This got deferred to 2.6. TGIS standalone is ready for use, but won't ship in 2.5 due to management priorities, caikit standalone dockerfile has merged upstream, we just need to build downstream and that's done

@Xaenalt Xaenalt reopened this Nov 16, 2023
@Xaenalt Xaenalt removed the rhods-2.4 label Nov 16, 2023
@Xaenalt
Copy link
Author

Xaenalt commented Nov 16, 2023

Additionally, prompt tuning workflow we're pretty close on having a working test for too

@heyselbi heyselbi changed the title Split caikit/TGIS ServingRuntime into three distinct images [STORY] Split caikit/TGIS ServingRuntime into three distinct images Nov 17, 2023
@heyselbi
Copy link

@bdattoma I will convert this issue to story and have separate issues for each image.

@bdattoma
Copy link

bdattoma commented Nov 17, 2023

This got deferred to 2.6. TGIS standalone is ready for use, but won't ship in 2.5 due to management priorities, caikit standalone dockerfile has merged upstream, we just need to build downstream and that's done

thanks for the update @Xaenalt! We will plan QE effort accordingly.

@bdattoma I will convert this issue to story and have separate issues for each image.

@heyselbi lgmt, thanks!!

@heyselbi
Copy link

heyselbi commented Jan 2, 2024

moved to JIRA

@heyselbi heyselbi closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature req From the Requirements document rhods-2.5
Projects
Status: Done
Status: No status
Status: Done
Development

No branches or pull requests

4 participants