This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
Added basic script to make api-token for culler #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maroroman
changed the title
vpavlin
reviewed
Jul 12, 2021
.jupyter/jupyterhub_config.py
Outdated
| @@ -25,6 +25,9 @@ | |||
| 'KUBERNETES_SERVICE_PORT': os.environ['KUBERNETES_SERVICE_PORT'], | |||
| 'JUPYTERHUB_LOGIN_URL': None | |||
| } | |||
|
|
|||
| idle_culler_api_token = str(uuid.uuid4()) | |||
There was a problem hiding this comment.
This cannot be re-generated on every restart of the JH as the culler container would not get the new value and API calls woulds start failing after restart.
Ideally implement 2 functions:
get_culler_secretset_culler_secret
Call the get_culler_secret here and only if the secret does not exist, call set_culler_secret
And use the loaded or created secret in the services dict
Also, the name of the secret should be something like jupyterhub-idle-culler and the key in it should be api_token
maroroman
force-pushed
the
feature/idle-culler
branch
2 times, most recently
from
d96de4d
to
f4d53ec
Compare
maroroman
force-pushed
the
feature/idle-culler
branch
from
f4d53ec
to
435f96d
Compare
2 tasks
maroroman
force-pushed
the
feature/idle-culler
branch
from
869b829
to
90882c0
Compare
vpavlin
reviewed
Jul 26, 2021
.jupyter/jupyterhub_config.py
Outdated
| def set_culler_secret(): | ||
|
|
||
| secret_data = str(uuid.uuid4()) | ||
| openshift.write_secret('jupyterhub-api-token', {'token': secret_data}) |
There was a problem hiding this comment.
Chanfe the name to something related to idle-culler - e.g. jupyterhub-idle-culler
maroroman
force-pushed
the
feature/idle-culler
branch
from
90882c0
to
ecc8ad8
Compare
maroroman
force-pushed
the
feature/idle-culler
branch
from
ecc8ad8
to
db0a847
Compare
|
/deploy |
This was referenced Jul 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
…
This introduces a breaking change
This Pull Request implements
Adds the JupyterHub Idle Culler as an external service
Description
This PR adds the idle culler as an external service and also exposes its api-token into a secret the the idle culler can read from.